Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/example advanced k8s #344

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Fix/example advanced k8s #344

merged 2 commits into from
Mar 12, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Mar 12, 2022

What does this PR do?

  • replacing hard coded region to data source value
  • disabling k8s-advanced and observability from e2e matrix list
    • k8s-advanced required variables to be passed (e.g. VPC id), these use cases needs to be addressed for the parallel e2e scope
    • observability TF plan time takes way longer than expected, disabling from e2e until example fixed.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan merged commit 87ab947 into main Mar 12, 2022
@askulkarni2 askulkarni2 deleted the fix/example-advanced-k8s branch March 16, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants