Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of depends_on for accelerator module, remove fargate_profiles from base example #356

Merged
merged 6 commits into from
Mar 18, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Mar 18, 2022

What does this PR do?

  • Create TF resource per IAM role policy attach for known policies
  • Add depends_on for eks-cluster-with-new-vpc example between accelerator module and vpc
  • Remove fargate_profiles from the example to allow GovCloud users to try the example.

Motivation

Cleaner TF destroy, avoid scenarios where VPC resources are deleted before EKS managed node groups does which leads to exceptions and the need of multiple destroy retries.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this change is to avoid Error: Invalid for_each argument issue with module level dependency using aws.vpc.

PR looks good to me. Few changes needs to be done. Thanks 👍🏼

examples/eks-cluster-with-new-vpc/main.tf Show resolved Hide resolved
modules/aws-eks-managed-node-groups/locals.tf Show resolved Hide resolved
modules/aws-eks-managed-node-groups/main.tf Show resolved Hide resolved
@Zvikan Zvikan marked this pull request as ready for review March 18, 2022 18:29
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kcoleman731 kcoleman731 merged commit b4cfef8 into main Mar 18, 2022
@vara-bonthu vara-bonthu deleted the fix/example-new-vpc-add-depndency branch March 19, 2022 09:17
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
fix: Update sealed secrets deployment to only reference secrets entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants