Updated the example for the private eks cluster with additional details and individual stacks for vpc, eks cluster and add-ons #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satveerkhurpa
requested review from
askulkarni2,
kcoleman731 and
vara-bonthu
as code owners
kcoleman731
reviewed
Apr 7, 2022
| This following command used to update the `kubeconfig` in your local machine where you run kubectl commands to interact with your EKS Cluster. | ||
|
|
||
| #### Step5: Run `update-kubeconfig` command | ||
| Here is the high level design of the solution. The solution has been split into 3 different TerraForm stacks for simplicity. |
kcoleman731
reviewed
Apr 7, 2022
| enable_vpa = true | ||
| enable_yunikorn = false | ||
| enable_argo_rollouts = false | ||
|
|
There was a problem hiding this comment.
extra line. Also add-ons default to false so feel free to omit add-ons no used.
kcoleman731
reviewed
Apr 7, 2022
| @@ -0,0 +1,116 @@ | |||
| /* | |||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Copyright headers not needed
kcoleman731
reviewed
Apr 7, 2022
| } | ||
| } | ||
|
|
||
| data "aws_region" "current" {} |
There was a problem hiding this comment.
put in a data.tf file for consistency
kcoleman731
reviewed
Apr 7, 2022
| public_subnet_ids = data.terraform_remote_state.vpc_s3_backend.outputs.public_subnets | ||
|
|
||
| cluster_name = join("-", [local.tenant, local.environment, local.zone, "eks"]) | ||
|
|
kcoleman731
reviewed
Apr 7, 2022
| subnet_ids = local.private_subnet_ids | ||
| } | ||
| } | ||
| } |
kcoleman731
reviewed
Apr 7, 2022
| default = {} | ||
| } | ||
|
|
||
|
|
kcoleman731
reviewed
Apr 7, 2022
| create = true | ||
| vpc_id = module.aws_vpc.vpc_id | ||
| security_group_ids = [ | ||
| data.aws_security_group.default.id] |
kcoleman731
reviewed
Apr 7, 2022
| output "public_subnets" { | ||
| description = "List of IDs of public subnets" | ||
| value = module.aws_vpc.public_subnets | ||
| } |
kcoleman731
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Looking great some nit comments for you. Please connect with @Zvikan on adding this into e2e tests.
@kcoleman731 - Pushed updates based on review comments. |
added 13 commits
April 13, 2022 14:35
This reverts commit ef790b4.
askulkarni2
reviewed
Jun 28, 2022
askulkarni2
approved these changes
Jun 28, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…ls and individual stacks for vpc, eks cluster and add-ons (aws-ia#388)
alidonmez
pushed a commit
to alidonmez/terraform-aws-eks-blueprints-1
that referenced
this pull request
Mar 25, 2023
fix: Add missing try entries in IDE environment variable block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the example to provision a private eks cluster. The updates includes individual terraform stacks to set up the VPC, the eks cluster and add-ons. also includes a high level design that shows the users on how they can use a jenkins host or a bastion host from the default vpc, a peering connection between the default vpc and the eks vpc to complete the set up of the private eks cluster.
Motivation
Users will have an example to provision a private eks cluster the right way.
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes