Fix/ running ArgoCd example on GovCloud #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camba1
requested review from
askulkarni2,
kcoleman731 and
vara-bonthu
as code owners
vara-bonthu
approved these changes
Apr 11, 2022
| @@ -34,7 +34,7 @@ data "aws_eks_cluster_auth" "cluster" { | |||
| } | |||
|
|
|||
| provider "aws" { | |||
| region = "us-west-2" | |||
| region = var.region | |||
There was a problem hiding this comment.
Like that. Should be done for all examples.
askulkarni2
reviewed
Apr 11, 2022
There was a problem hiding this comment.
@camba1 thanks for the PR. Question on the changing namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR has two changes to enhance the experience of running the argocd example in govCloud:
nginx namespaceinstead of theingress-nginx namespace. With the old namespace nothing would get created for Nginx beyond an empty namespace and the following error could be seen on Argo cd:Failed sync attempt to c0d70e7b110803dd967c91fec4cba9bd9622bcab: one or more objects failed to apply, reason: namespaces "nginx" not found (retried 1 times).Once the correct namespace is created, everything syncs properly and all appropriate resources are created
Motivation
Testing the ArgoCd example in govcloud to see if gitops would work as expected.
Additional Notes
For the ArgoCD example to be fully functional, it requires that PR 381 is passed as well to work properly, without that PR the load balancer will fail to deploy.