-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for HashiCorp Vault #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this. Thank you for the contribution. Minor comments and some 404s on urls. Assume the repo is not yet public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ksatirli thanks for the PR. Would love to test this out. Please let us know how we can access the addon repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ksatirli 👍🏼
LGTM!
Thanks @vara-bonthu - we're still working on getting some things on our side squared away before we publish the final (= If y'all could wait with merging this until then, that would be very helpful! |
(marked as draft; which I forgot to do when I opened this PR) |
Hey folks! We've made an initial version of the module code available at the links present in this PR. We anticipate down-the-road changes and may release newer module versions. For now, please give Vault a try with the included example. |
Thanks @ksatirli I have tested the Vault Add-on and it works fine 👍🏼 vabonthu>…/terraform/eks
▶ kubectl get pods -n vault | grep vault
vault-0 1/1 Running 0 4m5s
vault-agent-injector-7f6bdfc48d-sct5p 1/1 Running 0 4m5s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ksatirli thanks for contributing this addon. LGTM!
Hello maintainers 👋🏼 - adding this as draft while we get the final bits and pieces in places.
What does this PR do?
This PR adds a reference to the HashiCorp Vault blueprint.
Motivation
We love EKS and believe we should make it easier to manage and protect secrets (and sensitive data, in general) in an EKS workflow.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes