Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for HashiCorp Vault #406

Merged
merged 10 commits into from
Apr 17, 2022
Merged

Adds support for HashiCorp Vault #406

merged 10 commits into from
Apr 17, 2022

Conversation

ksatirli
Copy link
Contributor

Hello maintainers 👋🏼 - adding this as draft while we get the final bits and pieces in places.


What does this PR do?

This PR adds a reference to the HashiCorp Vault blueprint.

Motivation

We love EKS and believe we should make it easier to manage and protect secrets (and sensitive data, in general) in an EKS workflow.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR

As we are adding an external add-on, our example code lives in the external repository.

  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)

Not applicable.

  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this. Thank you for the contribution. Minor comments and some 404s on urls. Assume the repo is not yet public?

docs/add-ons/vault.md Outdated Show resolved Hide resolved
docs/add-ons/vault.md Outdated Show resolved Hide resolved
modules/kubernetes-addons/main.tf Show resolved Hide resolved
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksatirli thanks for the PR. Would love to test this out. Please let us know how we can access the addon repo.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ksatirli 👍🏼
LGTM!

@ksatirli
Copy link
Contributor Author

Thanks @vara-bonthu - we're still working on getting some things on our side squared away before we publish the final (= 0.9.0) of this add-on to the Terraform Registry.

If y'all could wait with merging this until then, that would be very helpful!

@ksatirli ksatirli marked this pull request as draft April 15, 2022 15:17
@ksatirli
Copy link
Contributor Author

(marked as draft; which I forgot to do when I opened this PR)

@ksatirli ksatirli marked this pull request as ready for review April 15, 2022 20:56
@ksatirli
Copy link
Contributor Author

Hey folks! We've made an initial version of the module code available at the links present in this PR.

We anticipate down-the-road changes and may release newer module versions.

For now, please give Vault a try with the included example.

@vara-bonthu
Copy link
Contributor

vara-bonthu commented Apr 16, 2022

Hey folks! We've made an initial version of the module code available at the links present in this PR.

We anticipate down-the-road changes and may release newer module versions.

For now, please give Vault a try with the included example.

Thanks @ksatirli

I have tested the Vault Add-on and it works fine 👍🏼

 vabonthu>…/terraform/eks 
▶ kubectl get pods -n vault | grep vault
vault-0                                 1/1     Running   0          4m5s
vault-agent-injector-7f6bdfc48d-sct5p   1/1     Running   0          4m5s

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksatirli thanks for contributing this addon. LGTM!

@askulkarni2 askulkarni2 merged commit a21a897 into aws-ia:main Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants