Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon): aws cloudwatch metrics helm addon #427

Merged
merged 9 commits into from
Apr 20, 2022
Merged

feat(addon): aws cloudwatch metrics helm addon #427

merged 9 commits into from
Apr 20, 2022

Conversation

askulkarni2
Copy link
Contributor

@askulkarni2 askulkarni2 commented Apr 19, 2022 •
edited

What does this PR do?

Fixes https://github.com/aws-ia/terraform-ssp-amazon-eks/issues/35

Motivation

With this we addon support for Container Insights.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 requested a review from Zvikan April 19, 2022 21:02
@askulkarni2 askulkarni2 changed the title Feature/aws cloudwatch metrics helm addon (feat): aws cloudwatch metrics helm addon Apr 19, 2022
@askulkarni2 askulkarni2 changed the title (feat): aws cloudwatch metrics helm addon feat(addon): aws cloudwatch metrics helm addon Apr 19, 2022
kcoleman731
kcoleman731 reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@kcoleman731 kcoleman731 added this to Working on it in Old EKS Blueprints (Archived) Apr 20, 2022
@kcoleman731 kcoleman731 removed this from Working on it in Old EKS Blueprints (Archived) Apr 20, 2022
vara-bonthu
vara-bonthu approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @askulkarni2 👍🏼 LGTM

@askulkarni2 askulkarni2 merged commit d0278d3 into main Apr 20, 2022
@askulkarni2 askulkarni2 deleted the feature/aws-cloudwatch-metrics-helm-addon branch April 20, 2022 18:52
@bryantbiggs bryantbiggs mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@Zvikan Zvikan Zvikan approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@askulkarni2 @kcoleman731 @bryantbiggs @vara-bonthu @Zvikan