Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add lb controller nginx example #457

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Apr 21, 2022

What does this PR do?

  • re-adds AWS lb controller to the nginx example
  • fix nginx example README to use correct cli command for TF destroy

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan
Copy link
Contributor Author

Zvikan commented Apr 21, 2022

Testing e2e with this change to ensure the example is working again.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zvikan
Copy link
Contributor Author

Zvikan commented Apr 21, 2022

Can confirm e2e nginx example passed(apply and destroy) using this change.

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 merged commit 989438a into main Apr 21, 2022
@askulkarni2 askulkarni2 deleted the nginx-example-fix branch April 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants