New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix multiple broken links #587
Conversation
| [HashiCorp Vault](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/docs/add-ons/vault.md) | Deploys HashiCorp Vault into an EKS cluster. | ||
| [VPA](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/docs/add-ons/vpa.md) | Deploys the Vertical Pod Autoscaler into an EKS cluster. | | ||
| [YuniKorn](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/docs/add-ons/yunikorn.md) | Deploys Apache YuniKorn into an EKS cluster. | | ||
| [Agones](agones.md) | Deploys Agones into an EKS cluster. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we want the full URL since this is coming from the mkdocs generated site pointing back to the individual addon REAMDEs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do, as the add-ons READMEs are all in the mkdocs docs/add-ons
folder. Actually, in the same folder as this index.md
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sidebar navigation pane (left) uses the local addon docs, the table links to the addon module READMEs (right/table)
If they both lead to the same place, then I would say we remove the table and rely on the sidebar navigation pane since it is redundant and another place we have to ensure is updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maintaining nav is a pain. Mkdocs actually complains about pages not included in nav.
I have successfully used an mkdocs plugin - awesome-pages - to totally remove this concern while keeping navigation under control.
If you prefer (and allow an additional mkdocs plugin), I can close this PR and issue another one which leverages awesome-pages plugin and maintain the same nav structure without the nav entries in mkdocs.yml.
Let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Manually deployed these changes to "Dev" preview version: https://aws-ia.github.io/terraform-aws-eks-blueprints/dev/ . |
What does this PR do?
Motivation
I clicked on some links which resulted in 404.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes