fix: Remove app.kubernetes.io/managed-by label
#591
Conversation
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
There was a problem hiding this comment.
app.kubernetes.io/managed-by is a recommended label used by Helm Chart so we can avoid using this with Terraform replace this with terraform.io/module. This will help both situations where customers either using Terraform or migrating to ArgoCD once deployed with Terraform.
| @@ -5,8 +5,7 @@ resource "kubernetes_namespace" "spark" { | |||
| } | |||
|
|
|||
| labels = { | |||
| job-type = "spark" | |||
| "app.kubernetes.io/managed-by" = "terraform-aws-eks-blueprints" | |||
There was a problem hiding this comment.
We can keep this label and also add additional label
app.kubernetes.io/created-by = terraform-aws-eks-blueprints
| @@ -2,10 +2,6 @@ resource "kubernetes_namespace_v1" "irsa" { | |||
| count = var.create_kubernetes_namespace && var.kubernetes_namespace != "kube-system" ? 1 : 0 | |||
| metadata { | |||
| name = var.kubernetes_namespace | |||
|
|
|||
| labels = { | |||
| "app.kubernetes.io/managed-by" = "terraform-aws-eks-blueprints" | |||
There was a problem hiding this comment.
Can be renamed the key with app.kubernetes.io/created-by. We can ignore managed-by here as ArgoCD may takeover the management once we enable ArgoCD.
The same applies to all the Helm Charts add-ons and IRSA K8s resources
| labels = merge( | ||
| { | ||
| "app.kubernetes.io/managed-by" = "Terraform" | ||
| "terraform.io/module" = "terraform-aws-eks-blueprints" |
There was a problem hiding this comment.
- Let's keep this label
app.kubernetes.io/managed-byforaws-authas its only managed by Terraformabut replace the value withterraform-aws-eks-blueprints - We also need to add another label here
app.kubernetes.io/created-by = terraform-aws-eks-blueprints
This will ensure who created and who is currently managing the resource. managed-by can be taken over by other sources like Helm when ArgoCD is enabled.
What does this PR do?
app.kubernetes.io/managed-bylabel from Terraform created resourcesMotivation
app.kubernetes.io/managed-bytag with cluster-autoscaler (maybe others) #499More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes