Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons/kubernetes-dashboard] remove fixed service account #599

Merged
merged 7 commits into from Jun 6, 2022
Merged

[addons/kubernetes-dashboard] remove fixed service account #599

merged 7 commits into from Jun 6, 2022

Conversation

Hokwang
Copy link
Contributor

@Hokwang Hokwang commented Jun 5, 2022

What does this PR do?

  • remove irsa (like metrics-server)
  • user can set namespace for kubernetes-dashboard
  • update chart version

Motivation

  • user can not set namespace
  • set_values is fixed (service account is "eks-admin" always), but helm chart can control this and in most cases, the user doesn't need to worry about service account setting.
  • no needed service-accout.yaml file

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @Hokwang. I am happy with this change but one small change required.

modules/kubernetes-addons/kubernetes-dashboard/locals.tf Outdated Show resolved Hide resolved
@vara-bonthu vara-bonthu merged commit db9c72a into aws-ia:main Jun 6, 2022
@Hokwang Hokwang deleted the patch-1 branch June 7, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants