-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update addons versions | Examples to use cluster version 1.22 | Fix self-managed-node example #634
Conversation
Additional changes pushed to the branch:
What I noticed so far by testings our e2e parallel with the above changes:
link to E2E workflows: https://github.com/aws-ia/terraform-aws-eks-blueprints/actions/runs/2512350932 (note failures re-ran). So far I have no identified any "sanity" failures (i.e. terraform apply and destroy works) related to 1.22 or addons with latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you!
@Zvikan This code has inspired me a lot, thanks. If I make it work with GitHub Actions, I need to install the AWS CLI first, right? |
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes