Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct docs on resources created in example #643

Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: Correct docs on resources created in example #643

merged 1 commit into from
Jun 17, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Correct docs on resources created in example

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test June 17, 2022 17:48 Inactive
@bryantbiggs
Copy link
Contributor Author

well .. I was not expecting those CI results

@bryantbiggs bryantbiggs merged commit c990739 into main Jun 17, 2022
@bryantbiggs bryantbiggs deleted the fix/docs branch June 17, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@Zvikan Zvikan Zvikan approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: examples/eks-cluster-with-new-vpc doesn't create a fargate profile
3 participants
@bryantbiggs @askulkarni2 @Zvikan