-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMR on EKS example update #675
Conversation
… into emr-on-eks-updates
examples/analytics/emr-on-eks/manifests/coredns-autoscaler.yaml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,29 @@ | |||
variable "name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason behind the use of variables in the examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change the folder name in future then the blog that refers to this example will break with our current option of using basename(path.cwd)
. I would like to ensure the name is always emr-on-eks
for this example so added this default value to the variable.
Customers can also change the name
if they want to by changing the variable or with tfvars without fiddling with the hardcoded values in main.tf
...ytics/emr-on-eks/examples/spark-execute/spark-scripts/pod-templates/spark-driver-nytaxi.yaml
Outdated
Show resolved
Hide resolved
...ics/emr-on-eks/examples/spark-execute/spark-scripts/pod-templates/spark-executor-nytaxi.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/emr-on-eks/manifests/coredns-autoscaler.yaml
Outdated
Show resolved
Hide resolved
… into emr-on-eks-updates
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes