Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR on EKS example update #675

Merged
merged 9 commits into from
Jun 24, 2022
Merged

EMR on EKS example update #675

merged 9 commits into from
Jun 24, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Jun 22, 2022

What does this PR do?

  • This example updated with custom Add-on config to support Spark workloads
  • Uses best practice to separate core node group and spark node group
  • Deploys add-ons to core node-groups while the Spark workloads runs on separate node group
  • CoreDNS Autoscaler added
  • Prometheus and VPA uplifted to latest versions
  • Some cleanup on existing examples

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test June 22, 2022 15:06 Inactive
@@ -0,0 +1,29 @@
variable "name" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason behind the use of variables in the examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the folder name in future then the blog that refers to this example will break with our current option of using basename(path.cwd) . I would like to ensure the name is always emr-on-eks for this example so added this default value to the variable.

Customers can also change the name if they want to by changing the variable or with tfvars without fiddling with the hardcoded values in main.tf

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test June 23, 2022 10:52 Inactive
@vara-bonthu vara-bonthu merged commit e80009e into main Jun 24, 2022
@vara-bonthu vara-bonthu deleted the emr-on-eks-updates branch June 24, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants