[addon module] velero - update version and add required values #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add create bucket
Hokwang
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
bryantbiggs
requested changes
Jun 27, 2022
|
OK, then I will remove bucket creation code. |
Hokwang
changed the title
bryantbiggs
reviewed
Jun 27, 2022
| provider: aws | ||
| backupStorageLocation: | ||
| bucket: ${bucket} | ||
| volumeSnapshotLocation: |
There was a problem hiding this comment.
could you elaborate on some of these changes, why they are important as defaults, etc. please
There was a problem hiding this comment.
Please refer to https://github.com/vmware-tanzu/velero-plugin-for-aws/blob/main/volumesnapshotlocation.md
it is required value.
When you don't use volumeSnapshotLocation.region, install could be success,
but backup always Partialy Failed,
it shows
$ velero backup logs daily-backup3 | grep -v "level=info"
time="2022-06-28T05:19:27Z" level=error msg="Error getting volume snapshotter for volume snapshot location" backup=velero/daily-backup3 error="rpc error: code = Unknown desc = missing region in aws configuration" error.file="/go/src/velero-plugin-for-aws/velero-plugin-for-aws/volume_snapshotter.go:82" error.function="main.(*VolumeSnapshotter).Init" logSource="pkg/backup/item_backupper.go:453" name=pvc-60373ea9-b6cd-4a62-8eb8-d51f3eb0e64c namespace= persistentVolume=pvc-60373ea9-b6cd-4a62-8eb8-d51f3eb0e64c resource=persistentvolumes volumeSnapshotLocation=default
bryantbiggs
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
CI failure is unrelated to this change - thanks for the update @Hokwang
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…a#693) Co-authored-by: Hokwang Lee <hk.lee@hybecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
user can create bucket in moduleMotivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes