Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable cluster log types upstream example #702

Merged
merged 2 commits into from Jun 28, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Jun 28, 2022

What does this PR do?

  • Enabling control plane logs for upstream example

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan marked this pull request as ready for review June 28, 2022 20:45
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please make smaller PRs that are easier to read, thanks

@Zvikan
Copy link
Contributor Author

Zvikan commented Jun 28, 2022

Lets wait for tfsec check to run and pass before merging please.

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test June 28, 2022 20:54 Inactive
@Zvikan
Copy link
Contributor Author

Zvikan commented Jun 28, 2022

tfsec checked, seems like fully-private cluster tf plan is taking longer than expected, but it's not related to this change therefore merging.

@Zvikan Zvikan merged commit c3feefa into main Jun 28, 2022
@Zvikan Zvikan deleted the tfsec-fix-upstream-example branch June 28, 2022 21:12
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
* fix: enable cluster log types upstream example

* fix: correct var name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants