Fix pod to pod communication between different nodes #706
Conversation
allamand
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
examples/karpenter/main.tf
Outdated
|
|
||
| enable_karpenter = true | ||
| enable_aws_node_termination_handler = true | ||
|
|
||
| tags = local.tags | ||
|
|
||
| depends_on = [module.eks_blueprints.managed_node_group_autoscaling_groups] |
There was a problem hiding this comment.
we want to avoid hard dependencies because any update to the managed node group will force the computed attributes in addons to be re-computed. This forces IRSA policies to be detached and re-attached but only after some time which results in failure to provision correctly
examples/karpenter/main.tf
Outdated
| @@ -195,6 +232,7 @@ module "vpc" { | |||
| private_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 10)] | |||
|
|
|||
| enable_nat_gateway = true | |||
| create_igw = true | |||
There was a problem hiding this comment.
this is the default so not needed
examples/karpenter/main.tf
Outdated
| @@ -208,12 +246,12 @@ module "vpc" { | |||
|
|
|||
| public_subnet_tags = { | |||
| "kubernetes.io/cluster/${local.name}" = "shared" | |||
| "kubernetes.io/role/elb" = 1 | |||
| "kubernetes.io/role/elb" = "1" | |||
There was a problem hiding this comment.
just curious - why the change to string formatted?
There was a problem hiding this comment.
It was present elsewhere so wanted to have same thing here
There was a problem hiding this comment.
You prefer to revert this ?
There was a problem hiding this comment.
I think the majority are in numeric format so lets try to stay consistent if you don't mind
Signed-off-by: sallaman <sallaman@amazon.com>
|
not sure whats up with our CI runners today so merging ahead |
What does this PR do?
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes