Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the GitLab CI example. #707

Merged
merged 169 commits into from
Jun 29, 2022
Merged

Updates to the GitLab CI example. #707

merged 169 commits into from
Jun 29, 2022

Conversation

satveerkhurpa
Copy link
Contributor

What does this PR do?

This PR updates the GitLab CI workflow so it can run any example from the repository. The documentation is also updated to reflect the changes.

Motivation

DataLab customer wanted to test provisioning an EKS cluster using EKS Blueprints and GitLab CI.

More

  • [Y ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ NA] Yes, I have added a new example under examples to support my PR
  • [ NA] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [ NA Yes, I have updated the docs for this feature
  • [ Y] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Satveer Khurpa added 30 commits April 5, 2022 15:02
Updates to the fully private eks cluster example
7dd7990
Updates based on code review comments
ad1f3dd
Updated main README.MD
d4d99c3
README updates
f2c5253
Fetching latest updates from upstream repo
b6dc3e0
Adding updated README.MD
067cb20
Updated example based on upstream updates
6f0edea
Updated docs
3e0e314
Updated region for local testing
ef790b4
Revert "Updated region for local testing"
91100af 
This reverts commit ef790b4.
Updated tenant var for local testing
b832d39
Update docs and var
a72fac9
Updated instructions
7ce7089
Updated tf state to be remote
81db07b
Adding auto.tfvars to aid remote backend
c7fb638
Update locals var to fix TF cloud plan error
52462ff
Revert "Update locals var to fix TF cloud plan error"
a5bf3ab 
This reverts commit 52462ff.
Updated vpc remote state var
0d7c73e
Remove cloud block.
f9ab53f
Update var in auto.tfvars
6c5dd1b
Added default value to region var
a5d826f
Testing external-dns with TF Cloud
b76e15c
Updated tenant
49ee7b9
Added region var
d1c98df
Updated region var
3987001
Updated to use a static region for aws provider
da446f9
Revert static region update
f64fd6d
TEsting with a static aws region
2aecd16
Remove the alias for region
e5a691a
Revert region updates
0aa2011
Satveer Khurpa and others added 20 commits June 16, 2022 12:56
vara-bonthu
vara-bonthu approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 9d25cfc into aws-ia:main Jun 29, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@satveerkhurpa @allamand
Updates to the GitLab CI example. (aws-ia#707)
b77be58 
Co-authored-by: Satveer Khurpa <khurpas@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@satveerkhurpa @bryantbiggs @vara-bonthu