Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ELB listener tagging policy #718

Merged
merged 1 commit into from Jul 1, 2022
Merged

Add ELB listener tagging policy #718

merged 1 commit into from Jul 1, 2022

Conversation

caleb-devops
Copy link
Contributor

@caleb-devops caleb-devops commented Jun 30, 2022 •
edited by bryantbiggs

What does this PR do?

  • Add ELB listener tagging policy
  • Update iam:CreateServiceLinkedRole policy to match the recommended policy found here.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@caleb-devops caleb-devops temporarily deployed to EKS Blueprints Test June 30, 2022 19:23 Inactive
bryantbiggs
bryantbiggs approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @caleb-devops 🎉

@bryantbiggs bryantbiggs merged commit 9a76dbb into aws-ia:main Jul 1, 2022
@caleb-devops caleb-devops deleted the 717-aws-load-balancer-controller branch July 5, 2022 17:17
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@caleb-devops @allamand
Add ELB listener tagging policy (aws-ia#718)
378cafc 
Co-authored-by: Caleb Hansard <caleb.hansard@caci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: aws-load-balancer-controller cannot create tags
2 participants
@caleb-devops @bryantbiggs