Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown links, check markdowns on PR #724

Merged
merged 1 commit into from Jul 1, 2022
Merged

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Jul 1, 2022

What does this PR do?

  • fix broken link in docs.
  • adjust markdown link action to run on PRs against main only when .md files modified.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 merged commit 281e121 into main Jul 1, 2022
@askulkarni2 askulkarni2 deleted the fix-markdown-links branch July 1, 2022 19:49
@@ -7,6 +7,12 @@ on:
paths:
- "**/*.md"

pull_request:
branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh - we should chat about this. we had this here but it doesn't work when adding new addons or new pages to docs since its checking whats currently live and not what "would be live" so it fails PRs.

not sure what the correct route is - maybe we want that and its up to reviewers to know if thats a true failure or a false failure since its getting added in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #725 for testing purposes, looks like the PR check fails as expected but this is coming from a branch created from the same repo, need to test this against a PR coming from external contributor from fork

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants