Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD admin password update #748

Merged
merged 2 commits into from
Jul 8, 2022
Merged

ArgoCD admin password update #748

merged 2 commits into from
Jul 8, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Jul 8, 2022 •
edited by askulkarni2

What does this PR do?

  • Allowing users to pass ArgoCD Admin password using set_sensitive values
  • Example to show how to create a Secrets Manager password and use it for ArgoCD

Motivation

Fixes #728

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

askulkarni2
askulkarni2 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test July 8, 2022 17:45 Inactive
@bryantbiggs bryantbiggs merged commit f45b1c8 into main Jul 8, 2022
@bryantbiggs bryantbiggs deleted the argocd-admin-password branch July 8, 2022 18:00
@Zvikan Zvikan mentioned this pull request Sep 8, 2022
Merged
6 tasks
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@vara-bonthu @bryantbiggs @allamand
ArgoCD admin password update (aws-ia#748)
8767dd6 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION] Flag argocd_admin_password_secret_name not working. Am I doing something wrong?
3 participants
@vara-bonthu @askulkarni2 @bryantbiggs