feat: Allowing override for irsa role name #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxf5025
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
bryantbiggs
reviewed
Jul 13, 2022
modules/irsa/main.tf
Outdated
| @@ -20,7 +20,7 @@ resource "kubernetes_service_account_v1" "irsa" { | |||
| resource "aws_iam_role" "irsa" { | |||
| count = var.irsa_iam_policies != null ? 1 : 0 | |||
|
|
|||
| name = format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa") | |||
| name = var.addon_context.irsa_iam_role_name != null ? var.addon_context.irsa_iam_role_name : format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa") | |||
There was a problem hiding this comment.
we can use:
Suggested change
| name = var.addon_context.irsa_iam_role_name != null ? var.addon_context.irsa_iam_role_name : format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa") | |
| name = try(var.addon_context.irsa_iam_role_name, format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa")) |
bryantbiggs
reviewed
Jul 13, 2022
modules/irsa/main.tf
Outdated
| @@ -46,7 +46,7 @@ resource "aws_iam_role" "irsa" { | |||
|
|
|||
| tags = merge( | |||
| { | |||
| "Name" = format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa"), | |||
| "Name" = var.addon_context.irsa_iam_role_name != null ? var.addon_context.irsa_iam_role_name : format("%s-%s-%s", var.addon_context.eks_cluster_id, trim(var.kubernetes_service_account, "-*"), "irsa"), | |||
There was a problem hiding this comment.
The role name is no longer controlled through tag Name like previously so we can just remove this tag
nxf5025
force-pushed
the
feature/adding-override-for-irsa-role-name
branch
from
0222b7d
to
6199558
Compare
bryantbiggs
approved these changes
Jul 14, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Gives the ability to override the IRSA IAM role name.
Motivation
In some cases we'd like to use a custom role name instead of the current default
Closes #333
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes