Addon kube prometheus stack #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form-aws-eks-blueprints into addon-kube-prometheus-stack
alanty
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
bryantbiggs
reviewed
Jul 13, 2022
bryantbiggs
reviewed
Jul 13, 2022
bryantbiggs
reviewed
Jul 13, 2022
bryantbiggs
reviewed
Jul 13, 2022
bryantbiggs
reviewed
Jul 13, 2022
bryantbiggs
reviewed
Jul 13, 2022
|
Overall, looks great @alanty - just a few questions since I'm not familiar with the chart or intentions and haven't tested locally yet |
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
bryantbiggs
reviewed
Jul 14, 2022
vara-bonthu
reviewed
Jul 15, 2022
There was a problem hiding this comment.
Thanks @alanty for this PR 👍🏼
I have few minor comments on this PR.
updates from review after testing
bryantbiggs
approved these changes
Jul 18, 2022
vara-bonthu
approved these changes
Jul 20, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
* init new module with empty files * init helm addon * create module parameters * use underscores not dashes * add default values.yaml file for chart * add actual values to values.yaml * remove commented AMP items * update documentation * update docs * pre-commit cleanup * add docs for kube-prometheus-stack * Apply suggestions from code review Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> * remove comments from review * Update modules/kubernetes-addons/kube-prometheus-stack/README.md * review and comment cleanup * add persistent storage for prometheus server * doc cleanup, adminPassword example Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds kube-prometheus-stack helm chart as a kubernetes add-on.
Motivation
There are existing addons for Prometheus, and Grafana. This installs both, a collection of useful dashboards, and the Prometheus Operator CRDs in one solution.
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes