Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Combine the EFS CSI example with the stateful example #770

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Combine the EFS CSI example with the stateful example

Motivation

  • We have a stateful example that shows how to backup clusters using velero, and a aws-efs-csi example which shows adding just the EFS CSI driver and EFS resources. It doesn't make sense to have these separate; instead they should be combined to show how to run stateful workloads including managing backups, etc.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test July 14, 2022 22:57 Inactive
@bryantbiggs
Copy link
Contributor Author

I think that check will fail because I removed the directory but it exists on main? maybe?

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good decision 👍🏼

@bryantbiggs bryantbiggs merged commit a5e5309 into main Jul 15, 2022
@bryantbiggs bryantbiggs deleted the chore/combine-stateful branch July 15, 2022 13:39
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants