feat: Add example for VPC-CNI custom networking #778
Conversation
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
| To teardown and remove the resources created in this example: | ||
|
|
||
| ```sh | ||
| terraform destroy -auto-approve |
There was a problem hiding this comment.
Single TF destroy works without any known ENI dangling issues?
There was a problem hiding this comment.
yes, but let me update to align with what we've been recommending
| # VPC-CNI Custom Networking ENIConfig | ||
| #--------------------------------------------------------------- | ||
|
|
||
| resource "kubectl_manifest" "eni_config" { |
There was a problem hiding this comment.
does it matter the order of this resource? should the manifest come first right after the cluster is created AND before the addons?
There was a problem hiding this comment.
yes order matters - the VPC CNI needs to be updated and the ENIConfig present before nodes are ready. However, since custom networking should be set at cluster creation, the order of operations work out as is naturally
| } | ||
| spec = { | ||
| securityGroups = [ | ||
| module.eks_blueprints.cluster_primary_security_group_id, |
There was a problem hiding this comment.
in my testing, i cant get this to work if there are more than one SG in the ENIConfig
What does this PR do?
terraform-aws-eksmodule to v18.26.3 which is latest - update is to allow use of dedicated control plane subnets which are recommended for expanding data plane without cluster disruptionMotivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes