Updated a typo in the documentation for the private eks cluster example #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 5, 2022 15:02
satveerkhurpa
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
| @@ -96,6 +96,7 @@ We will deploy the EKS cluster from the Cloud9 instance that was deployed to the | |||
| 2. Install Kubernetes tools on the Cloud9 instance. | |||
| - [Kubectl](https://Kubernetes.io/docs/tasks/tools/) | |||
| 3. Create an IAM role for the Cloud9 workspace and attach the IAM role to your workspace. This IAM role should have enough permissions to provision an EKS cluster. | |||
|
|
|||
There was a problem hiding this comment.
why this breakline?
askulkarni2
approved these changes
Jul 19, 2022
vara-bonthu
approved these changes
Jul 20, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…le (aws-ia#787) * Updates to the fully private eks cluster example * Updates based on code review comments * Updated main README.MD * README updates * Adding updated README.MD * Updated example based on upstream updates * Updated docs * Updated region for local testing * Revert "Updated region for local testing" This reverts commit ef790b4. * Updated tenant var for local testing * Update docs and var * Updated instructions * Updated tf state to be remote * Adding auto.tfvars to aid remote backend * Update locals var to fix TF cloud plan error * Revert "Update locals var to fix TF cloud plan error" This reverts commit 52462ff. * Updated vpc remote state var * Remove cloud block. * Update var in auto.tfvars * Added default value to region var * Testing external-dns with TF Cloud * Updated tenant * Added region var * Updated region var * Updated to use a static region for aws provider * Revert static region update * TEsting with a static aws region * Remove the alias for region * Revert region updates * Formatted code * Updated cluster name * Updated stage var to be unique * Cleanup * Fixed acm cert domain * Adding additional addons * Adding sample nginx config * README updated with instructions for Terraform Cloud * Cleanup * Updates to run the private eks cluster from bastion * Updated EKS version * Updated VPC stack * Updated VPC stack with TF Cloud * Updated stack for TF Cloud * Updates to read vpc id and subnet ids from vars * Updated vars * Updated addons * Updated terraform cloud provider for state * bug fixes * Updated CSI driver add-on config * Disable EBS driver * Remove nginx * disable external dns * cleanup * Updates to the VPC stack * Updated public and private VPC config * Updated region * Updated all stacks for us-east-1 * Updated cluster name * Updated cluster name * Updated eks cluster domain * Updated cert domain * Cleanup * Adding other add-ons * Updated stacks for prometheus related updates * Fixed typo * Updated base.tfvars with prometheus endpoint * Updated CSI driver version * Updated CNI version * Updated EKS stack with Bottle rocket details * Added tags * Enable LB controller * Updates to add-ons for testing fixes * Disable argocd workloads * Disable AMP to test * Revert earlier commit and test AMP * disable AMP * disable prometheus and lb controller * Testing external dns issue * Enable external_dns * Switched to the original repo for addons * Disable add-ons * Revert "Disable add-ons" This reverts commit c080268. * Rolling back addons * Disable external-dns * Updating addon repo config * Updating addon repo config * enable externaldns * disable nginx and external_dns * Updated eks cluster domain * fmt * Test removing CSI driver * Restore addons * Updated README * Switching to 1.21 * Disable AMP * Revert "Disable AMP" This reverts commit c123109. * Temp disable AMP * Enable KEDA * Update EKS version nodegroups and managed addon * Remove unused var * Fixes to get cluster name * Testing external dns * Updated acm_cert var * Updated cluster name * Add Keda * Updated EKS version * multitenancy stack updates * Rebased from origin * Updated region * Updated the eks stack. * Fixed module name * Fixed errors * cleanup * Updated private vpc subnet CIDR block range * cleanup * Updates * cleanup * Updates * updates * disable argocd * updates * updates * Cleanup * Updated README.MD * Updates to provision the VPC, peer, Cloud9 instance * Updated base.tfvars for the eks stack * Updated TF Cloud workspace details * Updated docs * Updated docs * Adding the add-ons module * Updates to add-ons * Doc updates * Disable VPC CNI as it is getting stuck in creating state * Updates to create an IAM instance profile for the Cloud9 instance * Cleanup * Cleanup * Updated the IAM vars with empty default values * Enable VPC CNI managed add-on * Updated IRSA condition to include aud:sts.amazonaws.com * bug fix IRSA * Updated IRSA module for missing condition * Updates to get latest version of addons * Precommit updates * Doc updates * Updates to the OIDC provider for the addons module * TF Format * Removed TF Cloud State management config * Create base.auto.tfvars * Updated VPC names * Delete base.auto.tfvars * Cleanup * Terraform fmt * Updates based on PR comments * Updated the GitLab CI example * Linting updates * Fixed typo * Removed extral line Co-authored-by: Satveer Khurpa <khurpas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a documentation typo in the "fully private eks cluster" example.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes