Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ArgoCD readme update, bcrypt usage #792

Merged
merged 3 commits into from
Jul 20, 2022
Merged

fix: ArgoCD readme update, bcrypt usage #792

merged 3 commits into from
Jul 20, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Jul 20, 2022

What does this PR do?

  • Updating ArgoCD example README to align with other examples READMEs
  • Fixing ArgoCD admin password to be hashed using bcrypt

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test July 20, 2022 17:56 Inactive
bryantbiggs
bryantbiggs approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test July 20, 2022 18:17 Inactive
@Zvikan Zvikan merged commit 8e35fec into main Jul 20, 2022
@Zvikan Zvikan deleted the 791/argocd-readme branch July 20, 2022 19:43
@bryantbiggs bryantbiggs mentioned this pull request Jul 20, 2022
Closed
1 task
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Zvikan @allamand
fix: ArgoCD readme update, bcrypt usage (aws-ia#792)
37079c2 
* fix: bcrypt argocd secret manager password

* fix: readme for argocd example

* chore: trim trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zvikan @bryantbiggs