Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ec2:DescribeImages to karpenter IAM to support v0.14 #807

Merged
merged 3 commits into from Aug 11, 2022
Merged

add ec2:DescribeImages to karpenter IAM to support v0.14 #807

merged 3 commits into from Aug 11, 2022

Conversation

FernandoMiguel
Copy link
Contributor

Signed-off-by: Fernando Miguel github@FernandoMiguel.net

What does this PR do?

Adds ec2:DescribeImages to karpenter IAM policy

Motivation

Karpenter v0.14 will require a new permission
https://github.com/aws/karpenter/pull/2169/files#diff-7c5cd36388230ea106cff266bf0ab314b88b940b523b5acf523746f7baa496b7R117

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for 0.14 to be released and update the karpenter example to demonstrate this new functionality and verify the permissions are correct

@FernandoMiguel
Copy link
Contributor Author

Lets wait for 0.14 to be released and update the karpenter example to demonstrate this new functionality and verify the permissions are correct

it's in the module, not the example.
adding the extra policy today won't change it in anyway, but I'm fine with waiting until it is released, and we can bump the version too

@FernandoMiguel
Copy link
Contributor Author

A rc is out for testing
https://github.com/aws/karpenter/releases/tag/v0.14.0-rc.0

Sadly I'm off on annual leave and unable to test anytime soon, prior to release.

@bryantbiggs
Copy link
Contributor

This is now released https://github.com/aws/karpenter/releases/tag/v0.14.0

Would you mind updating the default addon version to point to this latest release, then we can merge this. We can also include #836 in this PR as well, thanks!

@FernandoMiguel
Copy link
Contributor Author

@bryantbiggs I'll pick this up tomorrow.
Thanks for looking into it.

@bryantbiggs bryantbiggs self-requested a review August 10, 2022 18:42
@bryantbiggs bryantbiggs dismissed their stale review August 10, 2022 19:06

version is released and we can proceed

@FernandoMiguel
Copy link
Contributor Author

We can also include #836 in this PR as well, thanks!
@bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.

Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel FernandoMiguel temporarily deployed to EKS Blueprints Test August 11, 2022 18:11 Inactive
@FernandoMiguel
Copy link
Contributor Author

@bryantbiggs ready for review

@bryantbiggs
Copy link
Contributor

We can also include #836 in this PR as well, thanks!
@bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.

Its a one line change, I think its ok to add it here

@FernandoMiguel
Copy link
Contributor Author

We can also include #836 in this PR as well, thanks!
@bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.

Its a one line change, I think its ok to add it here

up to you :)

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@bryantbiggs bryantbiggs merged commit a6b850f into aws-ia:main Aug 11, 2022
@FernandoMiguel FernandoMiguel deleted the add-karpenter-ec2-DescribeImages branch August 16, 2022 01:12
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants