Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct IRSA module name used to not default to null through coalesce() #808

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Correct IRSA module name used to not default to null through coalesce()
    • Because of the use of optional variable attributes, when a value is not provided it defaults to null which is a valid value inside a try() block and for IAM role names. When the value is null, Terraform will provide a value for it which is not the desired default behavior. Instead, we want to use a custom name if provided, otherwise fall back to the format provided by the module

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test July 27, 2022 13:56 Inactive
@bryantbiggs bryantbiggs merged commit 1c8b07c into main Jul 27, 2022
@bryantbiggs bryantbiggs deleted the fix/irsa-default-name branch July 27, 2022 16:38
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: irsa roles are not being created with correct name for aws_for_fluentbit
2 participants