Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create quota if user provided one, Pin and use previous TF lint version #820

Merged
merged 4 commits into from
Aug 2, 2022
Merged

fix: create quota if user provided one, Pin and use previous TF lint version #820

merged 4 commits into from
Aug 2, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Aug 2, 2022 •
edited
Loading

What does this PR do?

  • Create quota resource only if user passed quota key in the teams map
  • Updating pre-commit workflow to use pinned TF lint version (previous version for now)

Motivation

Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

Examples:
https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/7636331056?check_suite_focus=true
https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/7619057100?check_suite_focus=true

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test August 2, 2022 16:47 Inactive
@Zvikan Zvikan mentioned this pull request Aug 2, 2022
Closed
1 task
askulkarni2
askulkarni2 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zvikan Zvikan changed the title fix: create quota if user provided one fix: create quota if user provided one, Pin and use previous TF lint version Aug 2, 2022
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test August 2, 2022 18:30 Inactive
@Zvikan Zvikan merged commit f7f1708 into main Aug 2, 2022
@Zvikan Zvikan deleted the 819-teams-quota branch August 2, 2022 23:26
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Zvikan @allamand
fix: create quota if user provided one, pin and use previous TF lint …
dc2aa56 
…version (aws-ia#820)

* fix: create quota if user provided one

* fix: pin and use previous tf lint version

* fix: correct gh action ENV substitution

* fix: end of file pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [teams] Kubernetes provider panic when adding application teams without specifying quota
3 participants
@Zvikan @askulkarni2 @bryantbiggs