Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fluentbit use correct cw retention variable #822

Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix: fluentbit use correct cw retention variable #822

merged 1 commit into from
Aug 3, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Aug 3, 2022

What does this PR do?

  • Using correct variable to set the fluentbit cw log group retention in docs and example.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test August 3, 2022 18:47 Inactive
@Zvikan Zvikan merged commit 7064fbb into main Aug 3, 2022
@Zvikan Zvikan deleted the 786/aws_for_fluentbit_cw_log_group_retention branch August 3, 2022 20:30
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Zvikan @allamand
fix: fluentbit use correct cw retention variable (aws-ia#822)
262dcdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [kubernetes-addons -> aws_for_fluentbit] aws_for_fluentbit_cwlog_retention_in_days doesn't work
2 participants
@Zvikan @bryantbiggs