feat: Allow setting set_values through helm_config for AWS load balancer controller addon
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alancer controller addon
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
bryantbiggs
commented
Aug 9, 2022
| <<-EOT | ||
| clusterName: ${module.eks_blueprints.eks_cluster_id} | ||
| region: ${local.region} | ||
| vpcId: ${module.vpc.vpc_id} |
There was a problem hiding this comment.
we previously had to replicate the values file here in order to set the vpcId for running the AWS LBC on Fargate. now we can set just the additional values we need to provide to the AWS LBC addon
bryantbiggs
commented
Aug 9, 2022
| depends_on = [ | ||
| kubernetes_namespace_v1.sample_app[0] | ||
| ] | ||
| yaml_body = templatefile("sample_app.yaml", { |
There was a problem hiding this comment.
flattened to one multi-resource yaml file with templating so that we can map dependencies (by passing namespace from namespace resource)
| @@ -6,7 +6,7 @@ locals { | |||
| name = local.name | |||
| chart = local.name | |||
| repository = "https://aws.github.io/eks-charts" | |||
| version = "1.4.2" | |||
| version = "1.4.3" | |||
Zvikan
approved these changes
Aug 10, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…alancer controller addon (aws-ia#834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
set_valuesthroughhelm_configfor AWS load balancer controller addonMotivation
set_valuesallows for the default values file to stay as is as the minimum required values, and users can pass in any additional through thevar.helm_config.set_values. The motivation for being able to set additional values - to able to set the pod disruption budget on the AWS LBC for better HA (discovered during testing for cluster upgrade guidance)More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes