chore: Only run CI checks when necessary (affected files changed) #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
Zvikan
approved these changes
Aug 9, 2022
bryantbiggs
force-pushed
the
chore/only-run-ci-when-necessary
branch
from
5755ca0
to
7424f6e
Compare
…ual workflow run - weird
bryantbiggs
commented
Aug 10, 2022
.github/workflows/plan-examples.yml
Outdated
| # if: "contains(github.event_name, 'pull_request')" | ||
| # uses: actions/checkout@v3 | ||
| # with: | ||
| # ref: refs/pull/${{github.event.pull_request.number}}/merge |
There was a problem hiding this comment.
@Zvikan do you know why we need the two different routes for checking out? plans only run on PRs so the standard checkout should suffice, no?
There was a problem hiding this comment.
According to #572
"Explicit checkout PR code as pull_request_target changes checkout behavior to default to source main."
If we'll leave it with default checkout while still using pull_request_target, it will use source main instead of the PR author branch & fork, so we need to explicitly checkout the PR
There was a problem hiding this comment.
ah ok thanks - I put that back as it was
|
waiting till issue is resolved, explains some of the "weirdness" in the checks that have been occurring
|
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes