feat: Allow users to specify multiple Route53 zones as well as cross account zones with external-dns

[bryantbiggs]

What does this PR do?

• Allow users to specify multiple Route53 zones as well as cross account zones with external-dns
• Allow setting set_values through helm_config variable
• Update default external-dns helm chart version to latest

Motivation

• This allows users to use external-dns addon with one or more Route53 zones in the current account, external account(s), or both while not requiring them to re-provide the values set in the default values.yaml file provided in the addon
• Closes [FEATURE] Additional helm values for kubernetes-addons which won't delete the default terraform-aws-eks-blueprints-addons#38
• Closes [Bug]: External DNS cannot find other account domain #516
• Closes [QUESTION] Multiple Route53 Zones with ExternalDNS #541
• Closes [FEATURE] Add support for private route53 dns zones deployment via the External DNS Add-On #638

More

• Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• Yes, I have added a new example under examples to support my PR
• Yes, I have created another PR for add-ons under add-ons repo (if applicable)
• Yes, I have updated the docs for this feature
• Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

• E2E Test successfully complete before merge?

Additional Notes

[vara-bonthu]

LGTM 👍🏼

[Zvikan]

LGTM, minor questions/comments

[Zvikan]

do we know what was the original reason for having zoneIdFilters set? can we safely remove it? checking https://github.com/bitnami/charts/blob/master/bitnami/external-dns/values.yaml#L609-L611 I am not sure, does external DNS know automatically which zone id to use? iirc domain filter is what used mainly but I might be wrong

[bryantbiggs]

yes, I looked this up as well and it all looks to be optional. so to provide better flexibility, I think defaulting to the minimum required values and letting users opt in to additional values will scale better (they now can choose to set zone ID filters, zone name filters, domain name filters, etc. or not)

[Zvikan]

Nit question: does it matter if source comes before count (and do we need extra line in-between)? looking at other modules it's usually source->count

[bryantbiggs]

does it matter - no. its just my OCD in that its typically source directly under the module declaration. the other changes are just whitespace to break out to sections:

module "foo" {
  source = "<URL/PATH>

  count or for_each
  
  parameters
  
  tags
  
  depends_on
}