Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix for oidc issue url for irsa module #839

Merged
merged 2 commits into from Aug 10, 2022
Merged

hotfix for oidc issue url for irsa module #839

merged 2 commits into from Aug 10, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Aug 10, 2022 •
edited by Zvikan

What does this PR do?

  • Fixing a breaking change for IRSA module

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 10, 2022 15:31 Inactive
@Zvikan Zvikan mentioned this pull request Aug 10, 2022
Closed
1 task
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test August 10, 2022 15:52 Inactive
@Zvikan Zvikan merged commit d013755 into main Aug 10, 2022
@Zvikan Zvikan deleted the hotfix-irsa-module branch August 10, 2022 16:24
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@vara-bonthu @Zvikan @allamand
hotfix for oidc issue url for irsa module (aws-ia#839)
5d78cc5 
* hotfix for oidc issue url for irsa module

* fix: tf fmt

Co-authored-by: Zvikan <zvi8875@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@Zvikan Zvikan Zvikan approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IRSA: Commit 832 breaks IRSA config
3 participants
@vara-bonthu @bryantbiggs @Zvikan