chore: Update templates provided to aid in collaboration and following the process #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
bryantbiggs
commented
Aug 11, 2022
| @@ -1,23 +1,30 @@ | |||
| --- | |||
| name: Feature request | |||
| about: Suggest an idea for this project | |||
| title: '[FEATURE] <title>' | |||
There was a problem hiding this comment.
we use labels so no need for the templated [FEATURE]
bryantbiggs
commented
Aug 11, 2022
|
|
||
| ### Community Note | ||
|
|
||
| * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request |
There was a problem hiding this comment.
pinched from Terraform AWS provider - just a more explicit statement of what we want users to do in terms of crowdsourcing feature request priority
bryantbiggs
commented
Aug 11, 2022
|
|
||
| ## Reproduction Code [Required] | ||
|
|
||
| <!-- REQUIRED --> |
There was a problem hiding this comment.
hard requirement, HARD requirement
bryantbiggs
commented
Aug 11, 2022
|
|
||
| <!-- REQUIRED --> | ||
|
|
||
| Steps to reproduce the behavior: |
There was a problem hiding this comment.
very important as well - these two pieces give us the closes representation of a reproduction
bryantbiggs
commented
Aug 11, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| ### What does this PR do? | ||
|
|
||
| <!-- A brief description of the change being made with this pull request. --> | ||
| - [ ] ✋ I am aware of the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests |
There was a problem hiding this comment.
Lets see if this helps reinforce the practice to flesh out details through issues first before committing to a large body of code in a PR
askulkarni2
approved these changes
Aug 11, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes