feat: Enable additional values through set_values
for cert-manager
#851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
set_values
forcert-manager
cert-manger
helm chart to latest versionsecurityContext
and use what the default provided by the helm chart https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml#L117Motivation
cert-manager
without needing to re-provide the default values invalues.yaml
. In addition, I have discovered that you can override the values in thevalues.yaml
throughset_values
. So in theeks-cluster-with-new-vpc
, you can see that--enable-certificate-owner-ref=false
but in thecert-manager
addon the default values.yaml file has--enable-certificate-owner-ref=true
. When deployed, the value is as set to--enable-certificate-owner-ref=false
which shows that it can override the default values. So this could open up some interesting use cases where we set opinionated defaults for recommendations (i.e. - set pod disruption budget) but users have the ability to override without needing to copy+paste the default values file and modifyingMore
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes