Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable additional values through set_values for cert-manager #851

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

Motivation

  • Closes cert manager default behavior is to keep certificate after ingress/c… #813
  • This change allows for additional values to be set on cert-manager without needing to re-provide the default values in values.yaml. In addition, I have discovered that you can override the values in the values.yaml through set_values. So in the eks-cluster-with-new-vpc, you can see that --enable-certificate-owner-ref=false but in the cert-manager addon the default values.yaml file has --enable-certificate-owner-ref=true. When deployed, the value is as set to --enable-certificate-owner-ref=false which shows that it can override the default values. So this could open up some interesting use cases where we set opinionated defaults for recommendations (i.e. - set pod disruption budget) but users have the ability to override without needing to copy+paste the default values file and modifying

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test August 12, 2022 21:21 Inactive
@bryantbiggs bryantbiggs merged commit bd188d7 into main Aug 13, 2022
@bryantbiggs bryantbiggs deleted the chore/cert-manager-opt-values branch August 13, 2022 15:37
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants