Spark Operator example update with best practices #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
requested review from
askulkarni2,
kcoleman731,
bryantbiggs and
Zvikan
as code owners
askulkarni2
reviewed
Aug 15, 2022
examples/analytics/spark-k8s-operator/helm-values/aws-for-fluentbit-values.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/helm-values/aws-for-fluentbit-values.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/helm-values/aws-for-fluentbit-values.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/helm-values/aws-for-fluentbit-values.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/helm-values/aws-for-fluentbit-values.yaml
Outdated
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/spark-samples/pyspark-pi-job-yunikorn.yaml
Show resolved
Hide resolved
examples/analytics/spark-k8s-operator/spark-samples/tpcds-benchmark-1t.yaml
Outdated
Show resolved
Hide resolved
askulkarni2
reviewed
Aug 17, 2022
bryantbiggs
approved these changes
Aug 23, 2022
1 task
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
* Spark Operator example update with best practices * pre-commit hooks updates * tflint fix added * Removed default values from values.yaml * added comment for docker image * comments with - updated with same length * removed vpc cidr from locals * upated locals with vpc endpoints * Updated the link for asg tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Spark Operator example updated with best practices
Closes Issue: #850
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes