Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-managed Apache Airflow on EKS #878

Merged
merged 27 commits into from
Aug 24, 2022
Merged

Self-managed Apache Airflow on EKS #878

merged 27 commits into from
Aug 24, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Aug 22, 2022

What does this PR do?

  • This PR deploys Apache Airflow Add-on on EKS
  • Production ready deployment example with instructions
  • Github Docs page

Closes the issue: #810

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Running Apache Airflow on Kubernetes is the common pattern for Data teams. This example will help customers to build production ready Apache Airflow on EKS.

This is also a request from few AWS customers

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 22, 2022 17:28 Inactive
@vara-bonthu
Copy link
Contributor Author

vara-bonthu commented Aug 23, 2022

Agree. We should we move the MWAA example under Analytics folder and then rename the folders to managed-airflow and self-managed-airflow.

The main difference is that MWAA has nothing to do with EKS unlike self-managed airflow hosted on EKS. MWAA example is only to trigger the job on EKS

I have added additional information to Docs(apache-airflow.md) and Readme as well.

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 23, 2022 10:36 Inactive
@vara-bonthu
Copy link
Contributor Author

Check Markdown links / markdown-link-check error is expected as the link is not available in MAIN until this PR is merged

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - few minor details to correct on the CI checks and then good to go !

@vara-bonthu
Copy link
Contributor Author

Looks great - few minor details to correct on the CI checks and then good to go !

Plan error seems to be related to RAY example. Let me see if that needs fixing


Error: Error in function call

  on main.tf line 156, in module "eks_blueprints_kubernetes_addons":
 156:     values = [templatefile("${path.module}/helm-values/kube-stack-prometheus-values.yaml", {
 157:       hostname = var.eks_cluster_domain
 158:     })]
    ├────────────────
    │ path.module is "."
    │ var.eks_cluster_domain is null

Call to function "templatefile" failed:
./helm-values/kube-stack-prometheus-values.yaml:6,[27](https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/7971539678?check_suite_focus=true#step:8:28)-[35](https://github.com/aws-ia/terraform-aws-eks-blueprints/runs/7971539678?check_suite_focus=true#step:8:36): Invalid template
interpolation value; The expression result is null. Cannot include a null
value in a string template..

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 23, 2022 12:12 Inactive
@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 23, 2022 13:28 Inactive
@vara-bonthu vara-bonthu changed the title Apache Airflow on EKS Self-managed Apache Airflow on EKS Aug 23, 2022
@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 23, 2022 22:13 Inactive
@vara-bonthu vara-bonthu merged commit f4d6db6 into main Aug 24, 2022
@vara-bonthu vara-bonthu deleted the airlflow-feature branch August 24, 2022 07:38
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
* Airflow helm addon example

* Airflow helm addon example

* Airflow helm addon example

* Airflow deployment docs added

* Airflow deployment docs added

* Airflow doc added

* Postgres db version updated

* removed commented code

* Updates to ariflow values

* added region data source

* Added versions file

* Added PVC for EFS

* Update modules/irsa/outputs.tf

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

* Update modules/irsa/outputs.tf

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

* s3 module added and updated with comments

* resolved conflicts with variables

* Docs updated

* removed irsa outputs to avoid count issues

* Updates to values and readme

* Updates to readme and values

* fix to tfsec warnings

* Terraform helm release issue fixed with airflow

* removed static password

* removed special characters for postgres password

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants