Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/external secrets irsa #889

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

Pacobart
Copy link
Contributor

@Pacobart Pacobart commented Aug 24, 2022

What does this PR do?

Adds support for IRSA creation for external-secrets helm deployment.

To use, add secret arn's list and pass via external_secrets_secrets_manager_arns to submodule

module "eks_addons" {
  enable_external_secrets        = true
  external_secrets_secrets_manager_arns = ["secret_arn_here"]
  external_secrets_ssm_parameter_arns = ["secret_arn_here"]
  external_secrets_helm_config = {}
}

Motivation

Missing feature blocking us from using aws-eks-blueprints provided submodule

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Pacobart Pacobart temporarily deployed to EKS Blueprints Test August 25, 2022 14:16 Inactive
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - once you fix the CI checks (trailing new line) everything should be green

@Pacobart Pacobart temporarily deployed to EKS Blueprints Test August 25, 2022 17:28 Inactive
@bryantbiggs bryantbiggs merged commit 3a0f5c8 into aws-ia:main Aug 25, 2022
@Pacobart Pacobart deleted the feat/external-secrets-irsa branch August 25, 2022 18:01
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Co-authored-by: Parker Barthlome <pbb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants