Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(aws-ebs-csi-driver): add capability to deploy into self managed mode #896

Conversation

jmenan
Copy link
Contributor

@jmenan jmenan commented Aug 25, 2022

What does this PR do?

Closes #577

add capability to deploy aws-ebs-csi-driver addon into self managed mode

Motivation

Currently the aws-ebs-csi-driver managed addon does not allow any configuration changes.

For example, deploying aws-ebs-csi-driver on "tainted" nodes is not supported and this can be problematic in some cases.

Until the modification of the addon in EKS managed mode is possible, I propose to be able to deploy "ans-ebs-csi-driver" in self managed mode with its helm chart

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan
Copy link
Contributor

Zvikan commented Aug 25, 2022

Thank you for creating this PR, but I do not see any related issue/s to this PR.
Please ensure to follow our Contributing Guidelines.
Thanks.

@jmenan
Copy link
Contributor Author

jmenan commented Aug 25, 2022

Thank you for creating this PR, but I do not see any related issue/s to this PR. Please ensure to follow our Contributing Guidelines. Thanks.

Hello,

Thank you for your feedback, I was going to create an issue but I saw that an issue already existed for a problem similar to mine.

I have just added the issue to my PR.

Does this look right to you?

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use #558 as a reference since it follows the same pattern. Note that we'll need to add more documentation around the two different routes users can use to deploy this addon, etc.

@jmenan
Copy link
Contributor Author

jmenan commented Aug 29, 2022

Please use #558 as a reference since it follows the same pattern. Note that we'll need to add more documentation around the two different routes users can use to deploy this addon, etc.

Hello @bryantbiggs .
Thank you for your feedback, I have just taken it into consideration and updated my PR accordingly.

@jmenan jmenan requested review from bryantbiggs and removed request for kcoleman731, askulkarni2, vara-bonthu and Zvikan August 29, 2022 13:05
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jmenan !

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test August 29, 2022 14:58 Inactive
@bryantbiggs bryantbiggs merged commit f2e7772 into aws-ia:main Aug 29, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
…mode (aws-ia#896)

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: j_menan <julien.menan@bedrockstreaming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] how can I use helm chart for aws-ebs-csi-driver
3 participants