Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kubecost to Kubernetes addon #901

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

florentio
Copy link
Contributor

@florentio florentio commented Aug 27, 2022

What does this PR do?

Closes #894

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs
Copy link
Contributor

Great addition, thank you! Lets again add this to an existing example - lets add this to the eks-cluster-with-new-vpc and the karpenter examples. We also need to enable the EBS CSI driver since we now default to EKS 1.23 so you'll need to ensure those examples have enable_amazon_eks_aws_ebs_csi_driver = true as well. Again, thank you for the contribution 🎉

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test August 29, 2022 15:08 Inactive
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @florentio !

examples/kubecost/main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit 6b0d7f2 into aws-ia:main Aug 29, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADDON] Kubecost
2 participants