Feature/e2e tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
requested changes
Nov 30, 2021
|
|
||
| 1. Use the following CloudFormation template to setup a new IAM role. | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
Nice to have this as a TF resource
There was a problem hiding this comment.
Hi @vara-bonthu, I spoke to @kcoleman731 and since this is meant for our internal usage we do not need a terraform example here.
kcoleman731
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #50
Description of changes:
Create a GitHub Action that uses the GitHub OIDC provider to assume a role in a "test" account where we can run an e2e test using a canonical example.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.