Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add fsx:UpdateFileSystem permission to aws-fsx-csi-driver addon #912

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

vale21
Copy link
Contributor

@vale21 vale21 commented Aug 30, 2022

What does this PR do?

Adding "fsx:UpdateFileSystem" action in the policy, in order to allow dynamic resize of the File System. Without this updated policy, a resize request in PVC results in an error. With this policy, insted, volume resizing works.

Closes #911

Adding "fsx:UpdateFileSystem" action in the policy, in order to allow dynamic resize of the File System. Without this updated policy, a resize request in PVC results in an error. With this policy, insted, volume resizing works.

Motivation

Volume resizing is required for me, but it can be required for many other users

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Adding "fsx:UpdateFileSystem" action in the policy, in order to allow dynamic resize of the File System. Without this updated policy, a resize request in PVC results in an error. With this policy, insted, volume resizing works.
@vale21 vale21 temporarily deployed to EKS Blueprints Test August 30, 2022 11:02 Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Could you please provide the use case that you use FSx for Lustre?

@vale21
Copy link
Contributor Author

vale21 commented Aug 30, 2022

Thanks for the PR 👍

Could you please provide the use case that you use FSx for Lustre?

Hi. No specific use case as of now. We are building an MSP and we are considering to offer FSX as an option to our clients

@bryantbiggs bryantbiggs changed the title Including "fsx:UpdateFileSystem" action in the policy fix: Add fsx:UpdateFileSystem permission to aws-fsx-csi-driver addon Aug 30, 2022
@bryantbiggs bryantbiggs merged commit 015834f into aws-ia:main Aug 30, 2022
@vale21 vale21 deleted the patch-1 branch August 30, 2022 16:15
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-fsx-csi-driver IRSA policy does not allow volume resizing
3 participants