Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct kubecost repo URL #915

Merged
merged 2 commits into from
Aug 30, 2022
Merged

fix: Correct kubecost repo URL #915

merged 2 commits into from
Aug 30, 2022

Conversation

florentio
Copy link
Contributor

@florentio florentio commented Aug 30, 2022 •
edited by bryantbiggs
Loading

What does this PR do?

This PR fix the repo url for kubecost helm add-on
Closes #913

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@florentio florentio temporarily deployed to EKS Blueprints Test August 30, 2022 14:15 Inactive
@florentio florentio mentioned this pull request Aug 30, 2022
Closed
@bryantbiggs bryantbiggs changed the title Fix/kubecost repo fix: Correct kubecost repo URL Aug 30, 2022
@bryantbiggs bryantbiggs merged commit bdbceb2 into aws-ia:main Aug 30, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@florentio @allamand
fix: Correct kubecost repo URL (aws-ia#915)
d40ebda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubecost chart failing to download
2 participants
@florentio @bryantbiggs