Support forcing type on Helm chart set attribute
#943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain values in a Kubernetes resource _must_ be a string and Kubernetes will complain if the value is of another type rather than automatically convert it into a string. An example of this problem would be the value `true` on a `Pod` label - in YAML, this must be `"true"` for Kubernetes to be satisfied. This adds a new optional attribute for the `set` element of all `*_helm_config` variables which allows the user to switch from the default behaviour of handling the `value` - `auto` - to `string`, which will force the `value` to be handled as text rather than a boolean or number. Fixes aws-ia#942
wjam
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
bryantbiggs
approved these changes
Sep 9, 2022
| @@ -43,6 +43,7 @@ resource "helm_release" "addon" { | |||
| content { | |||
| name = each_item.value.name | |||
| value = each_item.value.value | |||
| type = try(each_item.value.type, null) | |||
There was a problem hiding this comment.
this should be string by default... without it, many places fail
There was a problem hiding this comment.
this is an optional argument so null is what should be used to default to the resource's default value https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release#type
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Certain values in a Kubernetes resource _must_ be a string and Kubernetes will complain if the value is of another type rather than automatically convert it into a string. An example of this problem would be the value `true` on a `Pod` label - in YAML, this must be `"true"` for Kubernetes to be satisfied. This adds a new optional attribute for the `set` element of all `*_helm_config` variables which allows the user to switch from the default behaviour of handling the `value` - `auto` - to `string`, which will force the `value` to be handled as text rather than a boolean or number. Fixes aws-ia#942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Allow the user to set the
typeattribute within thesetblock of thehelm_releaseresource if needed.Motivation
setsome boolean values on addon Helm configuration聽#942More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes
I've updated the
eks-cluster-with-new-vpcto prove it works, but noticed thatcert_manager_helm_configis usingset_valuesto configure Helm attributes - I don't thinkset_valuesworks?