Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Addon for nvidia device plugin #995

Merged
merged 11 commits into from
Sep 26, 2022
Merged

feat: Addon for nvidia device plugin #995

merged 11 commits into from
Sep 26, 2022

Conversation

askulkarni2
Copy link
Contributor

@askulkarni2 askulkarni2 commented Sep 26, 2022 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

New add-on for NVIDIA Device plugin. This enables customers to effectively use NVIDIA GPU instances.

Motivation

More

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 @bryantbiggs
Update docs/add-ons/nvidia-device-plugin.md
ae90fd5 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 19:18 Inactive
bryantbiggs
bryantbiggs approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only critical change is the create_namespace = true which I think we want by default, otherwise looks good

@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 19:30 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 19:58 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 21:03 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 22:38 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 26, 2022 22:50 Inactive
@askulkarni2 askulkarni2 mentioned this pull request Sep 26, 2022
Merged
@askulkarni2 askulkarni2 merged commit 632a698 into main Sep 26, 2022
@askulkarni2 askulkarni2 deleted the addon-nvidia-device-plugin branch September 26, 2022 23:10
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@askulkarni2 @bryantbiggs @allamand
feat: Addon for nvidia device plugin (aws-ia#995)
99d67ee 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADDON] NVIDIA Device Plugin
2 participants
@askulkarni2 @bryantbiggs