Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go test instructions #17

Merged
merged 7 commits into from
Mar 11, 2022
Merged

Add go test instructions #17

merged 7 commits into from
Mar 11, 2022

Conversation

tbulding
Copy link
Contributor

@tbulding tbulding commented Mar 7, 2022

Adding instructions for setting up terratest to test the module

drewmullen
drewmullen suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, can you also please delete any .terraform.lock.hcl files from the repo as part of this PR. not sure how those snuck in there!

.header.md Outdated Show resolved Hide resolved
.header.md Outdated Show resolved Hide resolved
drewmullen
drewmullen suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@drewmullen drewmullen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more small things please:

  • can you please rename the versions.tf file to provider.tf ?
  • 2nd, see comment

once thats done im 👍 and we can close all 3 issues

.header.md Show resolved Hide resolved
tlindsay42
tlindsay42 requested changes Mar 9, 2022
View reviewed changes
.header.md Outdated Show resolved Hide resolved
.header.md Outdated Show resolved Hide resolved
drewmullen
drewmullen approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tlindsay42
tlindsay42 approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@tlindsay42 tlindsay42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vsnyc vsnyc merged commit 4bee506 into aws-ia:main Mar 11, 2022
@drewmullen drewmullen mentioned this pull request Mar 24, 2022
Closed
This was referenced May 20, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewmullen drewmullen drewmullen approved these changes

@tlindsay42 tlindsay42 tlindsay42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tbulding @drewmullen @tlindsay42 @vsnyc