Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bert_demo documentation #52

Closed
tahouse opened this issue Dec 23, 2019 · 5 comments
Closed

bert_demo documentation #52

tahouse opened this issue Dec 23, 2019 · 5 comments
Assignees

Comments

@tahouse
Copy link

tahouse commented Dec 23, 2019

The current documentation for bert_demo mentions to "Use the Neuron compatible BERT-Large implementation and public BERT-Large weights to generate a saved model using steps outlined in public BERT documentation here. " (link: google-research/bert#146)

The public documentation referenced is (currently) an open github issue discussion on the BERT repository -- not public documentation. No full working example is currently available at that link. If there is a known/vetted solution, can you please add it to the the bert_demo so that users can replicate the demonstration?

Thank you

@HahTK
Copy link
Contributor

HahTK commented Dec 23, 2019

It appears you have been sent the bert_demo link before the right PRs were processed. Please look at the README again.

You will see that the right version of the README.md points to these links -

  1. To fine tune BERT -
    https://github.com/google-research/bert#sentence-and-sentence-pair-classification-tasks which generates the weights.
  2. To create a saved model -
    Use BERT fine-tuned model for Tensorflow serving google-research/bert#146 (comment)

The correct version of the README it refers to the answer to the issue used by one of the engineers to generate the saved model.

@HahTK
Copy link
Contributor

HahTK commented Dec 23, 2019

Let me know if this is sufficient or if further guidance is needed.

@AWSGH AWSGH self-assigned this Dec 23, 2019
@tahouse
Copy link
Author

tahouse commented Dec 30, 2019

I recommend you copy the necessary code into Neuron README/repo. This way it is self-contained and can easily be rerun by new users.

@HahTK
Copy link
Contributor

HahTK commented Jan 15, 2020

I updated the instructions to include all missing info.
Let me know if this works for you so that we can close the issue or fix other errors.
Thanks

@micwade-aws
Copy link
Contributor

Since we haven’t heard back in a while we are closing this issue, please reopen it if more support from us is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants