Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Testing: Create release testing workflow #3

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

majanjua-amzn
Copy link
Contributor

@majanjua-amzn majanjua-amzn commented Dec 7, 2023

Run E2E test on demand for when changes are made to the enablement script.

Changes:

  • Create new release testing workflow
  • Create E2E test workflow for EKS as in ADOT repo
    • Changes made to this to pull the testing resources directly from ADOT (by pulling ADOT repo altogether)
    • Removed steps specific to ADOT (removed release testing check for ADOT, removed failure metric emission)
    • Calling API ahead of validation as an improvement (same change is planned for ADOT repo)

Note: This workflow does not test on PR because the AWS credential configuration using OIDC does not work under the context of a PR build (permissions are automatically set to read instead of write for id-token) - example of the operation hanging

Testing:
https://github.com/aws-observability/application-signals-demo/actions/runs/7135333263

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@majanjua-amzn majanjua-amzn added the enhancement New feature or request label Dec 7, 2023
@majanjua-amzn majanjua-amzn self-assigned this Dec 7, 2023
@majanjua-amzn majanjua-amzn changed the title E2E Testing: Run test on PR E2E Testing: Create release testing workflow Dec 7, 2023
@harrryr
Copy link
Contributor

harrryr commented Dec 8, 2023

LGTM

@majanjua-amzn majanjua-amzn merged commit 396bc00 into main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants