Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since the docker-compose file in the example mounts the user's aws directory, I presume the intention was to allow the use of shared credentials in addition to environment credentials. In my own case, using shared credentials was desirable since we use aws sso so I've got a big session key as well as access & secret keys, and in any case I'd prefer that myself & other internal users have to do a lot of copy-pasting to test this out.
However, shared credentials didn't work. I eventually realized that because the collector was a golang from-scratch image,
$HOME
was undefined, and I was able to fix loading shared credentials by addingto my own compose file. However, it seems like it would be better to just define that in the dockerfile, so that's what I've done here.
I've also added a candidate rewrite of the example compose file. It's not required; could be cherry-picked out.
Testing: I have not tested it in any way
Documentation: None besides the comments