Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker shared creds #100

Merged
merged 3 commits into from Nov 10, 2020

Conversation

dradetsky
Copy link
Contributor

Description:

Since the docker-compose file in the example mounts the user's aws directory, I presume the intention was to allow the use of shared credentials in addition to environment credentials. In my own case, using shared credentials was desirable since we use aws sso so I've got a big session key as well as access & secret keys, and in any case I'd prefer that myself & other internal users have to do a lot of copy-pasting to test this out.

However, shared credentials didn't work. I eventually realized that because the collector was a golang from-scratch image, $HOME was undefined, and I was able to fix loading shared credentials by adding

      - HOME=/root

to my own compose file. However, it seems like it would be better to just define that in the dockerfile, so that's what I've done here.

I've also added a candidate rewrite of the example compose file. It's not required; could be cherry-picked out.

Testing: I have not tested it in any way

Documentation: None besides the comments

@codecov-io
Copy link

Codecov Report

Merging #100 (f5577da) into main (8719306) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   75.71%   75.71%           
=======================================
  Files           4        4           
  Lines          70       70           
=======================================
  Hits           53       53           
  Misses          9        9           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8719306...f5577da. Read the comment docs.

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it and made the fix. We'll update the doc.

@mxiamxia mxiamxia merged commit 64d7a62 into aws-observability:main Nov 10, 2020
JasonXZLiu pushed a commit to open-o11y/aws-otel-collector that referenced this pull request Nov 19, 2020
* fix soaking test

* fix aws ecr login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants